feat: Add support for attaching namespace metadata to Kubernetes SD
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes an existing issue (bug or feature), use the following keyword:
Closes: #7799
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.
- [ ]
CHANGE(fix or feature that would cause existing functionality to not work as expected) - [x]
FEATURE(non-breaking change which adds functionality) - [ ]
BUGFIX(non-breaking change which fixes an issue) - [ ]
ENHANCEMENT(non-breaking change which improves existing functionality) - [ ]
NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)
Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.
Add support for attaching namespace metadata to Kubernetes SD
Thanks for the PR! Don't we have an existing issue with ScrapeConfig CRD and scrape classes? It seems that we don't merge the scrape class' attach metadata when generating the configuration from ScrapeConfig.
Thanks @simonpasquier
Currently, there appears to be no issue, as the results have been uniformly processed via appendAttachMetadata.
Thanks for the work on this @dongjiang1989 ! š Is this PR still active? Iād love to use the namespace metadata feature and was wondering about its status.
Thanks for the work on this @dongjiang1989 ! š Is this PR still active? Iād love to use the namespace metadata feature and was wondering about its status.
Hi @dongjiang1989 seems the pr has some conflicts if you could check? Thanks
@heliapb and @sebastienrospars I'll fix it soon
@simonpasquier @heliapb PTAL
Hello @heliapb, do you have some times to review this PR please ? Thanks by advance.