ScrapeConfig CRD: Proposal For Extending The CRD Surface

[mviswanathsai]

Description

Proposal for extending the ScrapeConfig API surface to pave the way for graduation to v1beta1.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• [ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
• [ ] FEATURE (non-breaking change which adds functionality)
• [ ] BUGFIX (non-breaking change which fixes an issue)
• [ ] ENHANCEMENT (non-breaking change which improves existing functionality)
• [ x] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

[mviswanathsai]

Hey! any further comments?

[mviswanathsai]

This is still valid, can we mention which 3 SD's you meant here?

I don't think this is valid anymore, I have changed it to reflect the current scenario.

[mviswanathsai]

Above comment still valid

Not sure I understand what is implied here :)

[slashpai]

This is still valid, can we mention which 3 SD's you meant here?

I don't think this is valid anymore, I have changed it to reflect the current scenario.

Hmmm not sure while checking file changed it was still showing me same. But if you already updated it's ok.

[mviswanathsai]

Ah! my bad, I failed to push it.

[mviswanathsai]

PTAL @simonpasquier @slashpai

[simonpasquier]

@mviswanathsai my changes don't pass the doc linter. Would you mind fixing the format and I'll merge :)

[simonpasquier]

:partying_face:

[mviswanathsai]

Woah, finally!