Yoshi icon indicating copy to clipboard operation
Yoshi copied to clipboard

Rename "Menu" to "MenuItem"

Open maxmamis opened this issue 8 years ago • 2 comments

The name Menu is confusing — it sounds like a screenful of options. Most classes/protocols/etc in Yoshi ending with the word "Menu" actually represent individual menu items, I.E. cells. YoshiGenericMenu should be YoshiGenericMenuItem, etc.

maxmamis avatar Jun 27 '17 21:06 maxmamis

The existence of YoshiTableViewMenu complicates things, because it already has an associated protocol called YoshiTableViewMenuItem. On the other hand, that name itself is confusing, because it's a very specific kind of table view (allowing you to select one of several options) and that's not reflected by the name — in fact, it being a table view is really just an implementation detail, not the primary characteristic. Here's what I propose:

YoshiTableViewMenu becomes YoshiPickerMenuItem YoshiTableViewMenuItem becomes YoshiPickerOption

maxmamis avatar Jun 27 '17 21:06 maxmamis

These names are somewhat inherited from 1.0 and gets expanded, for backward-compatibility concern the name will stay the same in the foreseeable future, we may change the name in the next major breaking update.

ghvg1313 avatar Jun 29 '17 18:06 ghvg1313