Feature: Spacing between numbers in modal
Feature Request
Type: 💡 Feature
Current Behavior:
Currently, the modal does not format numbers correctly. When you enter a number like 123456789, it displays without any spaces. We need it to display as 123 456 789.
Steps to Reproduce:
- Go to
/dashboard - Click on
Add Asset - Click on
Add Account - Observe the number formatting issue as shown in the screenshot:
Suggested Solution: Modify the input fields for numbers to automatically insert spaces between every thousand. Ensure that these spaces are removed when the value is processed as a number.
Additional Context: No response
.take
Hi @Amirthananth - A person on discord is working on this. New person that wanted to try this one. Can fix a new issue.
Hey @Codehagen that person is me :) the name is different on discord and GitHub that's why the confusion 😅
Ahh! No worries. Then go for it 😁. The person who made this is going to review it after to see ⚡
@Codehagen I was wondering if we should space as the separator or comma as a separator ?
I think space is best. Since some countries have comma and some had dots. With spaceing they cant argue 😅
That sounds fair. We should go for spaces if we want to keep it generic. If we want to be specific to a region then maybe we can go for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString#
Ahh! No worries. Then go for it 😁. The person who made this is going to review it after to see ⚡
@Codehagen For sure!