Badget icon indicating copy to clipboard operation
Badget copied to clipboard

Feature: Enable TS strictness

Open matteobad opened this issue 2 years ago • 3 comments

Type of feature

💡 Feature

Current behavior

TS is not in strict mode. This doesn't allow us to have strict checks. More importantly:

  • We cannot enable some ESLINT recommended rules for typescript
  • It is against the TRPC suggestions

Suggested solution

Enable the following in the @projectx/tsconfig/base.json:

...
"strict": true,
"noUncheckedIndexedAccess": true
...

Additional context

No response

matteobad avatar Jan 29 '24 13:01 matteobad

Im open for it. If you want you can just change it for the next PR you make? Or you want me to take it?

Codehagen avatar Jan 30 '24 05:01 Codehagen

Enabling strictness will likely require some modifications, so I would prefer to keep it separate from other jobs just to make PR more reviewable. If you have the time I will concentrate on the BE

matteobad avatar Jan 31 '24 18:01 matteobad

Yes, i will do it. You focus on the BE ✨

Codehagen avatar Jan 31 '24 19:01 Codehagen