hamster-lib icon indicating copy to clipboard operation
hamster-lib copied to clipboard

setup: Only require configparser when native version unavailable

Open jtojnar opened this issue 8 years ago • 3 comments

On Python 3, configparser library is part of standard library. The configparser package therefore is not needed. For this reason, distributions such as Arch Linux do not even provide this package for Python 3, which in turn breaks the build.

This patch changes the setup.py to only add the configparser dependency when native configparser is not available.

jtojnar avatar Jun 07 '17 19:06 jtojnar

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 07 '17 19:06 CLAassistant

Codecov Report

Merging #232 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    96.25%   96.25%           
========================================
  Files            9        9           
  Lines          934      934           
  Branches       141      141           
========================================
  Hits           899      899           
  Misses          13       13           
  Partials        22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c54a9e6...05f1836. Read the comment docs.

codecov[bot] avatar Jun 07 '17 19:06 codecov[bot]

Apparently, it is possible to declare version-specific constraints: https://github.com/joke2k/faker/blob/f81cd517e35d72edbdb264d0ec6a0f93f8d37ab8/setup.py#L68-L78

jtojnar avatar Aug 08 '17 16:08 jtojnar