interactsh icon indicating copy to clipboard operation
interactsh copied to clipboard

fix: leak flag in client and server package

Open knakul853 opened this issue 5 months ago • 2 comments

closes: https://github.com/projectdiscovery/interactsh/issues/1245 in nuclei tests during parallel execution we had observed server and client package getting flagged as goroutine leaks. it was reproducible from the issue https://github.com/projectdiscovery/interactsh/issues/1245 added cleanup and avoid starting goroutine when client is created(it starts now when needed) and in server added cleanup state.

knakul853 avatar Sep 23 '25 11:09 knakul853

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch fix/goleak-client-server

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 23 '25 11:09 coderabbitai[bot]

relates: https://github.com/projectdiscovery/nuclei/pull/6490

knakul853 avatar Sep 23 '25 11:09 knakul853