capsule-proxy icon indicating copy to clipboard operation
capsule-proxy copied to clipboard
verified publisher icon projectcapsule

fix: allow wildcards on certificate generation

Open pepordev opened this issue 1 year ago • 2 comments

Fix #523

pepordev avatar Sep 12 '24 08:09 pepordev

As I commented in the issue linked to this PR, I think this doesn't work: wildcard domains require the DNS01 challenge.

May I ask you if you smoke-tested this change in your cluster?

prometherion avatar Sep 12 '24 08:09 prometherion

Smoke test here, LGTM to get merged.

prometherion avatar Sep 13 '24 07:09 prometherion

@ppodevlabs pls gpg sign all commits

oliverbaehler avatar Oct 08 '24 09:10 oliverbaehler

@ppodevlabs in case you missed last message by Oliver, thanks for the contribution!

prometherion avatar Oct 10 '24 15:10 prometherion

@ppodevlabs in case you missed last message by Oliver, thanks for the contribution!

sorry for the delay, i don't know where my notifications went... hehehe.

pepordev avatar Oct 15 '24 10:10 pepordev