atomic icon indicating copy to clipboard operation
atomic copied to clipboard

Atomic/scan.py: Fix scan error message (BZ #1508453)

Open baude opened this issue 8 years ago • 10 comments

Description

BZ #1508453 correctly points out that the error message points to the wrong file when telling the user it cannot find the scanner image or arguments.

Signed-off-by: baude [email protected]

Related Bugzillas

  • 1508453

Related Issue Numbers

Pull Request Checklist:

If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.

  • [ ] Unittests
  • [ ] Integration Tests

baude avatar Nov 01 '17 14:11 baude

LGTM

rhatdan avatar Nov 01 '17 14:11 rhatdan

change LGTM, tests aren't happy though.

TomSweeneyRedHat avatar Nov 01 '17 15:11 TomSweeneyRedHat

@baude Can we also put the actual path to the correct configuration file into that error message?

matusmarhefka avatar Nov 01 '17 15:11 matusmarhefka

bot, retest this please

baude avatar Nov 01 '17 15:11 baude

@matusmarhefka that would be a bit harder ... but if you feel strongly, i could attempt to do that.

baude avatar Nov 01 '17 15:11 baude

@baude I leave it up to you. But if it would require too many code changes, we can go with the current fix.

matusmarhefka avatar Nov 01 '17 15:11 matusmarhefka

is this preferred?

# sudo ./atomic scan registry.access.redhat.com/rhel7/openscap
The scanner configuration for 'openscap' in '/etc/atomic.d/openscap' is missing its image name or scanner arguments
#

baude avatar Nov 01 '17 15:11 baude

@baude Yes, that looks good.

matusmarhefka avatar Nov 01 '17 15:11 matusmarhefka

bot, retest this please

baude avatar Nov 16 '17 14:11 baude

bot, retest this please

ashcrow avatar Feb 12 '18 20:02 ashcrow