robrix icon indicating copy to clipboard operation
robrix copied to clipboard

Animate the typing notification bar in and out of the RoomScreen view

Open alanpoon opened this issue 1 year ago • 3 comments

https://github.com/user-attachments/assets/f1e2f667-957d-4a8b-9625-c4b9cd0de007

Fixed 3rd task of this issue https://github.com/project-robius/robrix/issues/155

Closes #155

alanpoon avatar Oct 09 '24 06:10 alanpoon

@alanpoon The vertical height of the notification background is a bit too large, can it be adjusted to be narrower?

Also, resolve the conflict.

ZhangHanDong avatar Oct 11 '24 08:10 ZhangHanDong

@alanpoon The vertical height of the notification background is a bit too large, can it be adjusted to be narrower?

Also, resolve the conflict.

Done.

alanpoon avatar Oct 11 '24 09:10 alanpoon

Nice job, looks really good!

Can you also make it sliding upwards when showing it too? That way the animation is symmetric when being shown and when being hidden.

I also think it'd look nicer if the animation was a little bit faster (like 25% faster), but that's ultimately up to you.

  • Added Sliding upwards when showing.
  • Sped up the animation
  • Height of typing_notice made narrower

https://github.com/user-attachments/assets/8dbc8eb2-3e45-4c41-a2ab-7a26cc09f94c

alanpoon avatar Oct 12 '24 03:10 alanpoon

resolved conflict and merged main

alanpoon avatar Oct 30 '24 08:10 alanpoon