codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

feat(RHOAIENG-25241): disable ray usage metrics by default

Open kryanbeane opened this issue 11 months ago • 3 comments

Issue link

What changes have been made

Made RAY_USAGE_STATS_ENABLED default to = 0, which == disabled. Added unit tests to ensure enabledment and disablement. Also did manual testing and verified that a deployed custom build image has a default env var of RAY_USAGE_STATS_ENABLED = 0 on both head and worker pods

I verified that the env was present on the cluster

I also deployed a custom codeflare-sdk build on cluster and verified that /tmp/ray/session_xxx/usage_stats.json file does not exist. This is where ray temp writes usage stats to on the head.

Verification steps

  • Build custom image of codeflare-sdk (which goes to .dist folder)
  • Drag that to jupyter notebook in your cluster or locally, use it to install codeflare in notebook
  • Create a cluster (don't specify envs) and ensure head and workers have the env in place with a value of 0

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Manual tests
    • [ ] Testing is not required for this change

kryanbeane avatar May 15 '25 20:05 kryanbeane

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.48%. Comparing base (78ec732) to head (e95f18f). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   92.45%   92.48%   +0.02%     
==========================================
  Files          24       24              
  Lines        1419     1423       +4     
==========================================
+ Hits         1312     1316       +4     
  Misses        107      107              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 15 '25 21:05 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 30 '25 07:05 openshift-ci[bot]

/approved

chipspeak avatar Jun 04 '25 13:06 chipspeak

/lgtm

chipspeak avatar Jun 04 '25 13:06 chipspeak