maddy icon indicating copy to clipboard operation
maddy copied to clipboard

[DO NOT MERGE] Not fixed completely

Open cha-ku opened this issue 6 years ago • 3 comments

Hey @progsource, I tried to fix this, and this is working as seen in https://regex101.com/r/a40XyN/1, but in the code it compiles but gives me std::regex_error at runtime. I am unable to figure out what could be causing this. I am a complete beginner in C++ so it's possible I am missing something.

cha-ku avatar Sep 06 '19 09:09 cha-ku

The regex tool says:

A quantifier following a lookaround serves no purpose, and can safely be removed from the regular expression

If I remove the + for both the places, where the tool says that, it runs again, but sadly not yet with the desired result.

I'll check on that more today.

progsource avatar Sep 10 '19 08:09 progsource

One of the problems, that I see here, is that the following

some (_text_) some more text

should actually result in

some (<em>text</em>) some more text

and

[some _text_ here](https://github.com/some_other_person)

should result in

[some <em>text</em> here](https://github.com/some_other_person)

progsource avatar Sep 10 '19 10:09 progsource

Ok I will take a look at this

cha-ku avatar Sep 10 '19 17:09 cha-ku