ThreadPool icon indicating copy to clipboard operation
ThreadPool copied to clipboard

fix for use with git submodules

Open FreddyFunk opened this issue 7 years ago • 5 comments

This PR solves conflicts when using this repo as a git submodule. This simplifies using this repo within large git projects.

FreddyFunk avatar Sep 26 '18 20:09 FreddyFunk

I think the main function should then be made conditional using preprocessor macros.

fogti avatar Sep 29 '18 19:09 fogti

Addressed feedback from @zserik .

Both commits might not be the most ideal solution. For the use of this thread pool only the ThreadPool.h file is nessesary while the example.cpp file is intended to be a show case for an example code. Therefore it would be the best solution integrated this example code into the README.md and remove the example.cpp file from the code base completly. Let me know what you think about this suggestion. I can quickly update this pull request to fullfil this suggestion if it gets approved.

FreddyFunk avatar Sep 30 '18 14:09 FreddyFunk

Ok, the solution to delete the example.cxx and put the content into README sounds good, especially because the example.cxx is so small.

fogti avatar Oct 03 '18 16:10 fogti

Done

FreddyFunk avatar Oct 04 '18 19:10 FreddyFunk

ok

fogti avatar Oct 04 '18 20:10 fogti