Jacob Lifshay
Jacob Lifshay
> ``` > 1662 | fn write_fmt(&mut self, fmt: fmt::Arguments) -> Result { ```
one other thing i noticed, this proposal needs to address error handling -- if the `io::Write` errors, `fmt::Write` will just return `fmt::Error` which has no data, how can you get...
I think we'll want 2 different APIs on io::Write: ```rust pub trait io::Write { /// allows E = &mut io::Result to easily retrieve the error without needing to hold onto...
> Nah, even that's too complicated. Let's just do this: > > That keeps things stupid simple. Now you can do whatever you want and we don't have to worry...
demo of moving `std::io::Error` into `core`: https://github.com/rust-lang/project-error-handling/issues/11#issuecomment-1761019324
we could put just the `OsStr` struct in `core` as an implementation detail, along with necessary trait impls, and put the rest in `std` with a re-export of `OsStr`...this would...
> Including `CStr` in this list is interesting because some methods, like `strip_prefix`, will require allocating into a `CString`. i think you meant `strip_suffix`? `strip_prefix` should be able to return...
maybe `CStr::split_once` could return something more like `(&[u8], &CStr)`?
wouldn't `CStrSlice` just be `[NonZeroU8]` (except that's kinda hard to work with currently due to lacking lots of byte string methods)
I will point out that `static_assert` in C++ is post-monomorphization, so I think it's a bad idea to use the same name in Rust for a pre-monomorphization version because people...