glab icon indicating copy to clipboard operation
glab copied to clipboard

`glab mr create` should respect default "remove source branch" value of repo

Open agentydragon opened this issue 4 years ago • 4 comments

Description When I create a MR with glab mr merge, the "remove source branch" does not get checked, despite me having that as a default.

Steps to Reproduce

  1. Set "remove source branch" as default in repo settings: image
  2. Create a MR with glab mr create --fill.

Expected Behavior

MR should be created with "remove source branch" pre-checked.

Actual Behavior

Created MR does not have the checkbox checked.

image

Possible Fix Not checking the default in repo when creating the MR?

Your Environment

  • Version used (Run glab --version): 1.12.1-99-gd118ca7; just tried updating glab to version 1.21.1 (2021-09-28), it still appears to occur in that release as well.
  • Operating System and version: Pop!_OS 20.04

agentydragon avatar Nov 16 '21 21:11 agentydragon

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

clemsbot avatar Dec 17 '21 02:12 clemsbot

Still present in version 1.22

Even if it stays this way, a short option for --remove-source-branch would be a good workaround.

gergelypolonkai avatar Jul 29 '22 16:07 gergelypolonkai

I've worked around by alias gmrc='glab mr create --remove-source-branch --yes' and maybe a couple other options that I need, iirc. That makes it go non-interactive and use my preferred setting.

On Fri, Jul 29, 2022, 09:52 Gergely Polonkai @.***> wrote:

Still present in version 1.22

Even if it stays this way, a short option for --remove-source-branch would be a good workaround.

— Reply to this email directly, view it on GitHub https://github.com/profclems/glab/issues/904#issuecomment-1199736488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFORDA4CIMKLPNW5Z44IODVWQD5XANCNFSM5IFJU7NA . You are receiving this because you authored the thread.Message ID: @.***>

agentydragon avatar Jul 29 '22 17:07 agentydragon

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

clemsbot avatar Aug 29 '22 03:08 clemsbot