glab icon indicating copy to clipboard operation
glab copied to clipboard

Add group issue boards to issue board view

Open tommyalatalo opened this issue 4 years ago • 6 comments

Description

This adds the ability to choose group level boards when viewing issue boards. Some additional flags such as label filtering are also added since the Gitlab issue boards are mainly just the column layouts including all issues in the project/group. "Opened" and "Closed" issue lists are now included in the view.

Related Issue

https://github.com/profclems/glab/issues/840

How Has This Been Tested?

Manually tested using existing group and project boards on a private Gitlab instance.

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation
  • [ ] Chore (Related to CI or Packaging to platforms)

tommyalatalo avatar Oct 28 '21 16:10 tommyalatalo

Codecov Report

Merging #893 (90389e4) into trunk (ce81f27) will decrease coverage by 0.21%. The diff coverage is 100.00%.

:exclamation: Current head 90389e4 differs from pull request most recent head 1879a6b. Consider uploading reports for the commit 1879a6b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #893      +/-   ##
==========================================
- Coverage   59.51%   59.30%   -0.22%     
==========================================
  Files          97       93       -4     
  Lines        7687     7433     -254     
==========================================
- Hits         4575     4408     -167     
+ Misses       2702     2637      -65     
+ Partials      410      388      -22     
Impacted Files Coverage Δ
commands/issue/list/issue_list.go 66.92% <100.00%> (-0.48%) :arrow_down:
commands/project/clone/repo_clone.go 63.57% <0.00%> (-1.50%) :arrow_down:
commands/variable/set/set.go 82.82% <0.00%> (-1.13%) :arrow_down:
commands/mr/list/mr_list.go 62.58% <0.00%> (-1.05%) :arrow_down:
commands/mr/mrutils/mrutils.go 66.46% <0.00%> (-0.40%) :arrow_down:
commands/root.go 77.77% <0.00%> (-0.28%) :arrow_down:
internal/config/config_file.go 31.63% <0.00%> (-0.06%) :arrow_down:
commands/ci/ci.go 100.00% <0.00%> (ø)
commands/project/repo.go 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce81f27...1879a6b. Read the comment docs.

codecov[bot] avatar Oct 29 '21 06:10 codecov[bot]

This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees.

clemsbot avatar Dec 21 '21 02:12 clemsbot

@profclems I finally came back to this after a long time. I've update the PR with some fixes, a pretty big refactoring to split the unwieldy command into smaller chunks, and made the board view styling more readable.

Have a look at this again when you have the chance and hopefully we can merge and close this sooner rather than later.

tommyalatalo avatar Mar 02 '22 19:03 tommyalatalo

What is the status on this? Haven't heard anything on this after pushing an updated solution.

tommyalatalo avatar Apr 29 '22 07:04 tommyalatalo

Hi @altosys, thanks a lot for this PR. I love this, however, we announced that this project is officially adopted by GitLab https://github.com/profclems/glab/issues/983#issue-1175723125. All new contributions should be made to the GitLab repo: https://gitlab.com/gitlab-org/cli

profclems avatar Aug 09 '22 17:08 profclems

This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees.

clemsbot avatar Sep 09 '22 03:09 clemsbot