profanity icon indicating copy to clipboard operation
profanity copied to clipboard

Mouse selection is not working properly

Open H3rnand3zzz opened this issue 2 years ago • 8 comments

Reported by another Profanity user.

Expected Behavior

When user holds LMB (left mouse button) and drag mouse, text selected.

Current Behavior

When user holds LMB and drags, selection is not happening.

Possible Solution

It might be related to #1943.

Steps to Reproduce (for bugs)

  1. Hold LMB, drag it.
  2. Text is not selected.

Context

The problem is not reproducible by me and some other users, but the user that has a problem claims that the problem appeared after he updated Profanity 17.01.24

Environment

Tilix, master branch of the profanity running in arch docker.

H3rnand3zzz avatar Jan 18 '24 17:01 H3rnand3zzz

I don't see how the mainloop can have any effect on this. Most likely that user updated his terminal, ncurses, tmux, tinfo or anything else on the system. Furthermore I cannot reproduce this issue with or without running in tmux.

jubalh avatar Jan 18 '24 19:01 jubalh

I still believe this is a user/system issue and not ours. Any feedback from the user?

jubalh avatar Jan 22 '24 08:01 jubalh

I still believe this is a user/system issue and not ours. Any feedback from the user?

The following experiment has been conducted: the user opened a second "window/session/tab" withing a same window with the profanity, the selection problem persisted on the profanity's side, but not on the other one. My conclusion is that the problem is somehow related to the new way that we process user input.

H3rnand3zzz avatar Jan 22 '24 12:01 H3rnand3zzz

the user opened a second "window/session/tab" withing a same window with the profanity

window within same window?

Maybe interesting to try with: xterm, vte based (gnome-terminal for example) with and without tmux (if they are a temux user).

jubalh avatar Jan 22 '24 12:01 jubalh

the user opened a second "window/session/tab" withing a same window with the profanity

window within same window?

Maybe interesting to try with: xterm, vte based (gnome-terminal for example) with and without tmux (if they are a temux user).

Tilix is similar to TMUX. Session was meant, not a window.

I opened profanity in tilix and the second window for illustration of the setup. Right window: selection is working; left window: does not (occasionally it does, once in 5-10 tries).

image

H3rnand3zzz avatar Jan 22 '24 14:01 H3rnand3zzz

Tilix is similar to TMUX.

Does it work without it?

jubalh avatar Jan 22 '24 14:01 jubalh

Tilix is similar to TMUX.

Does it work without it?

For me problem with Tilix is not reproducible with the same OS. Though I asked if it's reproducible for the user without the Tilix. image

H3rnand3zzz avatar Jan 22 '24 14:01 H3rnand3zzz

Does this behaviour happen for the user in xterm, other vte based terminal or only with Tilix? Does this happen only with latest master (containing gmainloop) or also before that, for example with 2ec94064ed341f0ea5b197a283c6ebfb15716bd0?

jubalh avatar Jan 23 '24 06:01 jubalh

Change reverted, it fixed the issue

H3rnand3zzz avatar Mar 14 '24 00:03 H3rnand3zzz