discovr icon indicating copy to clipboard operation
discovr copied to clipboard

effectsize_type is es_type

Open DominiqueMakowski opened this issue 1 year ago • 3 comments

in parameters

DominiqueMakowski avatar Nov 13 '24 12:11 DominiqueMakowski

It'd be helpful when you make these changes to add a message when people use the old argument. For example, 'the argument effectsize_type is now 'es_type', please change your code accordingly' is that possible?

profandyfield avatar Nov 13 '24 16:11 profandyfield

normally we do slowly deprecate it in a useful manner, I'm surprised why it hasn't printed a warning, will investigate

DominiqueMakowski avatar Nov 13 '24 16:11 DominiqueMakowski

In this case we indeed had a rather short period of deprecation warning, because the argument was name-conflicting with the effectsize package and caused some critical issues.

strengejacke avatar Jun 30 '25 13:06 strengejacke