p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Fix broken and missing links in En, Jp, zh-Hans contributior_docs web_accessibility.md

Open 22nds opened this issue 1 year ago • 5 comments

Most appropriate sub-area of p5.js?

  • [ ] Accessibility
  • [ ] Color
  • [ ] Core/Environment/Rendering
  • [ ] Data
  • [ ] DOM
  • [ ] Events
  • [ ] Image
  • [ ] IO
  • [ ] Math
  • [ ] Typography
  • [ ] Utilities
  • [ ] WebGL
  • [ ] Build process
  • [ ] Unit testing
  • [ ] Internationalization
  • [ ] Friendly errors
  • [X] Other (specify if possible)

p5.js version

latest

Web browser and version

all

Operating system

all

Steps to reproduce this

Steps:

  1. Go to https://github.com/processing/p5.js/blob/main/contributor_docs/web_accessibility.md
  2. Missing/incorrect links are in the second and third paragraph "If you want to make your sketches screen reader-accessible, visit the How to label your p5.js code tutorial.

If you want to use p5.js with a screen reader, visit the Using p5.js with a Screen Reader tutorial."

Corrections for English version:

  • Missing link How to label your p5.js code. Correct link is https://p5js.org/tutorials/writing-accessible-canvas-descriptions/
  • Link to Using p5.js with a Screen Reader tutorial doesn't work. Correct link is https://p5js.org/tutorials/p5js-with-screen-reader/

Affected docs are in the following languages: English, JP, zh-Hans

Please assign this issue to me and I'll submit PR.

22nds avatar Sep 03 '24 04:09 22nds

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

welcome[bot] avatar Sep 03 '24 04:09 welcome[bot]

Hi! Just wanted to check in on this since it's been a couple days. Is there anything else that needs to be done on filing this issue, per the bot? Or is there any other way I can help with this? This seems like a pretty easy fix; it'd be great to see it resolved and to see accessibility consequently improved

williamthazard avatar Sep 04 '24 19:09 williamthazard

Thanks @22nds for opening this issue, and @williamthazard for your interests in working on this. There are multiple broken links issues across p5.js repo and p5.js website repo, so it's taking us a bit longer to coordinate. For the particular links mentioned in this issue, they are fixed in the English version.

If you are interested, please feel free to open a PR to fix the links in ja and zh-hans translated version. Thank you!

Qianqianye avatar Sep 13 '24 06:09 Qianqianye

This issue is still opened. Please assign this issue to me and I'll submit PR.

Bhavyabhardwaj avatar Oct 04 '24 16:10 Bhavyabhardwaj

Hello @Qianqianye and maintainers,

I see that the fix is still needed for the Japanese (ja) and Simplified Chinese (zh-hans) translated files, as noted in your comment on September 13th.

I would like to take this on. I will locate the respective translated files for contributor_docs/web_accessibility.md and update the two broken links using the correct URLs provided in the issue description.

Since the scope is clearly defined for documentation updates, I can likely submit a Pull Request within the next 24 hours.

Please assign this issue to me. Thank you!

koushikcs562 avatar Nov 14 '25 15:11 koushikcs562