`nf` seems to have wrong prototypes

[IronBlood]

Most appropriate sub-area of p5.js?

• [ ] Accessibility
• [ ] Color
• [ ] Core/Environment/Rendering
• [ ] Data
• [ ] DOM
• [ ] Events
• [ ] Image
• [ ] IO
• [ ] Math
• [ ] Typography
• [X] Utilities
• [ ] WebGL
• [ ] Build process
• [X] Unit testing
• [ ] Internationalization
• [ ] Friendly errors
• [ ] Other (specify if possible)

p5.js version

main branch

Web browser and version

No response

Operating system

No response

Steps to reproduce this

This is generally a report about the documentation and test cases.

From the reference, the prototypes for nf are:

• nf(num, [left], [right])
• nf(nums, [left], [right])

However, from the source code, especially in doNf(num, left, right), there isn't check of type left === 'undefined', nor a default value for left, so when calling leftPart = leftPart.padStart(left, '0'), left cannot be undefined.

Also in the test suite of p5.prototype.nf, test cases are missing:

• result = nf(1234), if left is optional
• result = nf([1234, 3.141516, 3.141516e-2], 2) for an array of numbers to format

[welcome[bot]]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

[Akhilbisht798]

Hey, I am intrested in this isssue. As you said here.

 However, from the source code, especially in doNf(num, left, right), there isn't check of type left === 'undefined', nor a default value for left, so when calling leftPart = leftPart.padStart(left, '0'), left cannot be undefined

did you meant that left can be undefined because that will make more sense if i am not wrong.

[Akhilbisht798]

I can be wrong in this but i think p5._validateParameters('nf', arguments); Here the arguments are being checked so that they are always correct or something of that sort. But for test cases i think you are right we should have a test for array and test for only right argument.

[Rishab87]

I too agree with @Akhilbisht798, I think the same, only test cases should be updated , if no one working on it should I add missing test cases?

[Akhilbisht798]

@Rishab87 hey this issue is resolved and merged.

[Rishab87]

@Akhilbisht798 thank you for letting me know