p5.min.js does not include the licenses for bundled third party libraries (or itself)

[timmb]

Topic

The released p5.min.js file contains no license for p5js nor any licenses for the third party dependencies. However, searching through p5.js there are a few licenses left in there. (e.g. search for the text "MIT License"

I don't have much knowledge of licensing and just trying to ensure a sketch I'm releasing will be compliant. I believe all third party licenses need to be included either in the p5.min.js file or I need some way to include them within my own bundle.

Is there a switch on the minifcation process that should be preserving these in the minified file? Also, should the p5.js LGPL license not also be included within the minified file?

[welcome[bot]]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[Qianqianye]

Thanks @timmb for pointing this out.

@outofambit, can you share some thoughts on this? Thanks.

[stampyzfanz]

I don't know much about software licenses and I am not a lawyer, but based on my rudimentary understanding, licenses should be kept for both legal and ethical purposes. I identified lots of third party bundled code licensed under MIT which says in the license "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software".

I know this is a discussion, but there isn't much activity in it and I believe that the premise of my pull request is uncontentious although there are a few things I wasn't sure about that I put in the pull request. I can move them here to facilitate better discussion if that is preferred.