p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Links to wikipedia are broken

Open blackboxlogic opened this issue 7 months ago • 13 comments

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Windows

Web browser and version

Firefox (updated) and Chrome (updated)

Actual Behavior

Clicking a link to wikipedia brings me to a broken page.

Expected Behavior

Should arrive at wikipedia page

Steps to reproduce

Go to https://p5js.org/reference/p5.FFT/logAverages/ Click link in description "Octave Bands" Arrive at https://en.wikipedia.org/wiki/Octave_band/, but wikipedia doesn't expect the trailing slash. This same issue happens for all links to wikipedia. I found more by going to https://github.com/processing/p5.js/blob/v1.11.8/lib/addons/p5.sound.js and searching for "wiki"

Would you like to work on the issue?

nope.

blackboxlogic avatar Jun 26 '25 15:06 blackboxlogic

Thanks for filing this! This issue is open for work. It looks like the reference source (reference is built from code) does not have a trailing slash, so maybe trailing slashes are being added unnecessarily? May need a little bit more investigation

ksen0 avatar Jun 27 '25 16:06 ksen0

@blackboxlogic I would like to solve this issue, can you please assign it to me?

reshma045 avatar Jul 03 '25 07:07 reshma045

@reshma045 I don't seem to have permission to assign tickets. Maybe @ksen0 ?

blackboxlogic avatar Jul 03 '25 17:07 blackboxlogic

Thanks @reshma045!

davepagurek avatar Jul 03 '25 18:07 davepagurek

@davepagurek I've linked my PR to this issue, can you review it? Thank you

reshma045 avatar Jul 04 '25 07:07 reshma045

@reshma045 now that you've found this is more complicated than just deleting the slashes, do you still want this issue assigned to you?

blackboxlogic avatar Aug 05 '25 14:08 blackboxlogic

Hi @reshma045 , thanks for all your work on this so far! If you're still working on this issue or interested in it, please respond on the PR https://github.com/processing/p5.js-website/pull/892 in the next week (it's okay to ask for more time or for help, or to open the issue for someone else)

ksen0 avatar Aug 05 '25 18:08 ksen0

Hi @ksen0 and @blackboxlogic I apologize for the delay, but I’d like to continue working on this. Thanks

reshma045 avatar Aug 06 '25 03:08 reshma045

No problem @reshma045 thanks for working on it ! Just checking in to make sure you're still on it. Feel free to ask questions when you have them

ksen0 avatar Aug 06 '25 19:08 ksen0

Sure thank you @ksen0

reshma045 avatar Aug 08 '25 06:08 reshma045

@reshma045 ? are u still working on this issue or can I work on it , thanks

hxrshxz avatar Oct 08 '25 15:10 hxrshxz

Hi @hxrshxz, you can work on it.

reshma045 avatar Oct 09 '25 14:10 reshma045