Fixed deleteProject handler
Fixes #3023
Changes: In this modification, I added a return statement before deleteObjectsFromS3 to ensure the function returns the Promise returned by deleteObjectsFromS3. Then, I modified the handleProjectDeletion function to wait for the delete operation to complete using .then() and .catch() blocks to handle any errors during the S3 deletion process.
I have verified that this pull request:
- [x] has no linting errors (
npm run lint) - [x] has no test errors (
npm run test) - [x] is from a uniquely-named feature branch and is up to date with the
developbranch. - [x] is descriptively named and links to an issue number, i.e.
Fixes #123
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.
Thank you @lindapaiste for looking into it. I appreciate your effort to resolve the confusion. Please take your time, and let me know if you need any further assistance from my end.
This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.
Thank you @lindapaiste for bringing this to my attention. It seems there might be a discrepancy in the Git diff, possibly showing changes from the SASS PR that aren't directly related to our current task, I think there could be mainly three reasons:
- It's possible that changes from other branches, such as the SASS PR, may be inadvertently included during the branch creation or merging process.
- The Git history might have become tangled or unclear, leading to unexpected changes being displayed in the diff.
- If multiple components or features are being developed concurrently in the repository, it's easier for changes to overlap or conflict in the diff view.
To address this, we may need to review the Git history and ensure that proper branch management practices are followed. There might be some unnecessary changes or merges that need to be cleaned up. Your help in resolving this issue is greatly appreciated.
This looks good but I am extremely confused by why the Git diff is showing all the changes from the SASS PR. I think I can fix it for you (by merging the current branch into your branch) but not right now.
have a look on this @lindapaiste , Please take your time, and let me know if you need any further assistance from my end.
Thanks for your work on this! Due to the amount of time that's passed I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to reopen a new one or check out our other issues!