p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Fixed the issue cannot create a SharedArrayBuffer

Open goutamdh opened this issue 2 years ago • 1 comments

Fixes #2094

Changes: Set Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy headers This commit adds security headers to the server response to enable cross-origin isolation for shared memory operations in the p5.js editor. I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

goutamdh avatar Jan 06 '24 17:01 goutamdh

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Jan 06 '24 17:01 welcome[bot]

Thanks for your work on this! After testing this, I don't think what's here is the complete solution yet since the issue seems to still persist on my end! I don't exactly know what the right resolution looks like myself, but I feel like what's here is probably going in that vein. Since we have quite a few PRs open at the moment I'm going to close this one for now. I'm sorry that we couldn't get this one in, but please feel free to reopen this with any updates or check out our other issues!

raclim avatar Jun 24 '24 14:06 raclim