p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Eye Icon for Revealing and Hiding Passwords

Open perminder-17 opened this issue 2 years ago • 12 comments

Increasing Access

The proposed feature entails the addition of a small eye icon next to password input fields within the application's user interface. Users would have the option to click on this icon, toggling between two states:

  1. Password hidden
  2. Password revealed

Feature enhancement details

1.Improved User Experience: This feature would enhance the overall user experience by providing an option to easily view the entered password, reducing frustration associated with mistyped or forgotten passwords during the login or registration process.

2.Enhanced Security: Despite the password being temporarily visible, this feature does not compromise security since it is under the user's control. Passwords would still be securely stored and transmitted as usual.

3.Accessibility: The eye icon would be particularly helpful for users with visual impairments who rely on screen readers. They can easily verify their entered password before submission. image

perminder-17 avatar Sep 21 '23 17:09 perminder-17

@lindapaiste Can we work on this issue.??

perminder-17 avatar Sep 21 '23 17:09 perminder-17

@lindapaiste Can we work on this issue.??

Sure! FYI based on my quick googling it seems like the way to unobscure the text is by changing the <input> from type="password" to type="text" and back.

lindapaiste avatar Sep 21 '23 18:09 lindapaiste

Ok working on it..

perminder-17 avatar Sep 21 '23 18:09 perminder-17

@lindapaiste can u review?

perminder-17 avatar Sep 23 '23 18:09 perminder-17

@lindapaiste i want to work on these issue . Please assign it to me.

Ganaik2004 avatar Sep 27 '23 17:09 Ganaik2004

I'm done can I make pull request for this one

sudhanshuku01 avatar Sep 29 '23 09:09 sudhanshuku01

Yes , Thats true , we can have or simply we must have an eye icon for password and I think the better solution I have as I can do this in just a 2-3 lines of code , Assign me

Shashank0229 avatar Oct 01 '23 22:10 Shashank0229

Hello Sir

It's great to hear from you, I can contribute or can fix your bug , please allow me to contribute on it

Thank you

On Mon, Oct 2, 2023, 7:06 PM perminder-17 @.***> wrote:

Reopened #2466 https://github.com/processing/p5.js-web-editor/issues/2466.

— Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-web-editor/issues/2466#event-10526211288, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HOUAU2TMCYKO5OBW3RTS3X5K7NJAVCNFSM6AAAAAA5B5MRDGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGUZDMMRRGEZDQOA . You are receiving this because you commented.Message ID: <processing/p5. @.***>

Shashank0229 avatar Oct 02 '23 14:10 Shashank0229

@perminder-17 I want to work on this issue can you please assign it to me

Varun-45 avatar Oct 03 '23 07:10 Varun-45

is this issue still unresolved?? can i work on it

madtitan02 avatar Oct 23 '23 19:10 madtitan02

Just a note that we need to test this feature in Microsoft Edge and make sure that it works alongside the built-in behavior. We may need to hide the default eye with

::-ms-reveal {
    display: none;
}

It's probably more complicated to hide our eye and use the default one when in Edge.

See: https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal

lindapaiste avatar Oct 24 '23 15:10 lindapaiste

Ok @lindapaiste going to do that asap

perminder-17 avatar Oct 24 '23 16:10 perminder-17