p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Cannot edit names on SketchList or CollectionList using keyboard controls

Open lindapaiste opened this issue 2 years ago • 2 comments

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

The name turns into an input, but immediately closes.

This is because the "Enter" keyboard event which was used to select "Rename" is still being processed, and "Enter" will submit the form.

Expected Behavior

The name should turn into an input and stay that way until you press "Enter" again.

Steps to reproduce

Steps:

  1. Go to your /sketches page.
  2. Click somewhere on the page to focus.
  3. Press "Tab" until you focus on the dropdown at the end of the table row. image
  4. Press "Enter" to open the dropdown.
  5. Press "Tab" to focus on "Rename". image
  6. Press "Enter" to select "Rename".
  7. Try to edit the name...you can't.

I came across this issue while working on #2382 and it will be fixed in that PR. We could also implement a more immediate fix for just this issue if we deem it high-priority.

lindapaiste avatar Aug 16 '23 17:08 lindapaiste

hi @lindapaiste  ,I would like to fix this issue can you please assign it to me..?

gajanandh avatar Sep 05 '23 14:09 gajanandh

Hey @lindapaiste, I solved this issue locally, should I raise a PR??

Ankush263 avatar Sep 11 '23 20:09 Ankush263