processing
added unit test for p5.gain in es6
added unit tests for all the methods in p5.Gain
here are the test results and AUDIO GRAPH ( inspected with WEB AUDIO INSPECTOR) of this unit test
@therewasaguy
please review this PR !
Also, i have been using this amazing WEB AUDIO INSPECTOR tool to see the AUDIO GRAPHS
, I find it very useful while working with web audio API, i am curious if we can use this as integrated part of our codebase, it will really help the developers to understand and write codes ,specially when they can see what they are creating!
We may want to copy over just the can set the output level of gain Node test, since the current test file doesn't test changing the gain at all. But I think that's the only one that isn't covered now!
We may want to copy over just the
can set the output level of gain Nodetest, since the current test file doesn't test changing the gain at all. But I think that's the only one that isn't covered now!
okay got it, so can I open a PR to add the can set the output level of gain Node in the existing gain test?
Okay will do !!
On Wed, 4 Jan 2023, 02:58 Dave Pagurek, @.***> wrote:
yeah sounds good!
— Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-sound/pull/462#issuecomment-1370242254, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLHP3SE6DY7RHRQ4HWY4XDWQSKXTANCNFSM4MWPXVDA . You are receiving this because you commented.Message ID: <processing/p5. @.***>
Thanks @Abhijay007! I'll close this PR and carry over reviews on your new one.