pinecone-php icon indicating copy to clipboard operation
pinecone-php copied to clipboard

Add all supported versions of php to github workflow (8.1, 8.2, 8.3)

Open scotteuser opened this issue 1 year ago • 1 comments

Thank you for this excellent project. We have started using it in https://www.drupal.org/project/ai and will contribute back where we can. We would like to keep the module as compatible as possible with the range of PHP versions Drupal supports (https://www.drupal.org/docs/getting-started/system-requirements/php-requirements) which matches the wider PHP versions supported (https://www.php.net/supported-versions.php).

Tests currently support only PHP 8.2. This PR changes the github workflow to test 8.1, 8.2, and 8.3 + changes the composer.json to have a minimum version of PHP 8.1 (which is also what saloonphp/saloon requires).

Thank you!

scotteuser avatar Oct 02 '24 14:10 scotteuser

To note, I did run the tests locally in 8.1, 8.2, and 8.3 all passing fine.

scotteuser avatar Oct 02 '24 14:10 scotteuser

Very sorry about that; shouldn't have made the PR from master branch in my fork as ultimately we needed to unblock dependencies to stay compatible with supported Drupal versions. I could not see how to change source branch in the PR so I created a new one: https://github.com/probots-io/pinecone-php/pull/17 - apologies for the extra noise/extra work!

scotteuser avatar Jan 06 '25 05:01 scotteuser