no-response icon indicating copy to clipboard operation
no-response copied to clipboard

Test suite failing?

Open jasonrudolph opened this issue 7 years ago • 0 comments

I cloned this repository locally to investigate possible fixes to some of the open issues, and I discovered that three of the tests are failing for me:

$ node --version
v10.10.0

$ npm --version
6.4.1

$ npm i && npm test

> [email protected] test /Users/j/github/no-response
> mocha && standard

  NoResponse
    sweep
      1) creates a responseRequiredLabel if one does not exist
      2) does not create a responseRequiredLabel if it already exists
      3) searches for matching issues
    close
      when perform is set to false
        ✓ logs that this is a dry run
        ✓ does not close the issue
        ✓ does not post a comment
      when perform is set to true and there is no close comment
        ✓ logs that the issue is being closed
        ✓ closes the issue
        ✓ does not post a comment
      when perform is set to true and a close comment is included
        ✓ logs that the issue is being closed
        ✓ closes the issue
        ✓ posts a comment

  9 passing (10ms)
  3 failing

  1) NoResponse
       sweep
         creates a responseRequiredLabel if one does not exist:
     TypeError: Cannot read property 'slice' of undefined
      at Function.fromArray (node_modules/scramjet-core/lib/data-stream.js:574:19)
      at Object.fromArray (node_modules/scramjet-core/lib/index.js:39:32)
      at NoResponse.getClosableIssues (lib/no-response.js:76:37)

  2) NoResponse
       sweep
         does not create a responseRequiredLabel if it already exists:
     TypeError: Cannot read property 'slice' of undefined
      at Function.fromArray (node_modules/scramjet-core/lib/data-stream.js:574:19)
      at Object.fromArray (node_modules/scramjet-core/lib/index.js:39:32)
      at NoResponse.getClosableIssues (lib/no-response.js:76:37)

  3) NoResponse
       sweep
         searches for matching issues:
     TypeError: Cannot read property 'slice' of undefined
      at Function.fromArray (node_modules/scramjet-core/lib/data-stream.js:574:19)
      at Object.fromArray (node_modules/scramjet-core/lib/index.js:39:32)
      at NoResponse.getClosableIssues (lib/no-response.js:76:37)

npm ERR! Test failed.  See above for more details.

I also tried with Node 7 and Node 8 to see if the failures are possibly due to newer version of Node than the minimum version specified in package.json, but I got the same results with those other versions of Node.

Are these known failures, or is there perhaps additional setup that is required to run the test suite?

jasonrudolph avatar Sep 18 '18 15:09 jasonrudolph