ideas icon indicating copy to clipboard operation
ideas copied to clipboard

Automatically create a deployment for Pull request

Open jainkeval opened this issue 7 years ago • 4 comments

This bot will be for frontend projects. The bot will deploy site to heroku (may be) for one's pull request. So that the mentors will be able to review the changes easily.

@bkeepers @gr2m any suggestions?

I would like to work on this.

jainkeval avatar Apr 15 '18 07:04 jainkeval

if you are hosting only frontend then there are easier options available than heroku. Check surge.sh

itaditya avatar Apr 15 '18 09:04 itaditya

@itaditya That's correct! Some more options for the Frontend are Github Pages and Netlify.

panmona avatar Apr 15 '18 10:04 panmona

Why not to use Travis CI, it can deploy to Heroku as well.

kenorb avatar Apr 15 '18 12:04 kenorb

I like the idea, but unless I'm misunderstanding, I do this with Heroku Review Apps already: https://devcenter.heroku.com/articles/github-integration-review-apps

Review apps importantly only work on PRs from branches in the upstream repo, not forks. But with protected branches, maintainers can liberally give push access without worrying about master, and so the workflow works great.

Plus probot/settings is about the allow restricted branches to be configured from file, so even simpler to share this practice: https://github.com/probot/settings/pull/76

Review apps is a feature that’s part of Heroku’s GitHub Integration.

patcon avatar Apr 15 '18 18:04 patcon