MiniDexed icon indicating copy to clipboard operation
MiniDexed copied to clipboard

Hopefully a fix for "Modulation Range Error #562"

Open dcoredump opened this issue 2 years ago • 4 comments

I currently have no keyboard right here, so I cannot check the difference between MiniDexed and MicroDexed, sorry. But looking at the code I saw that I removed the calls to ControllersRefresh() when changing the range or target of the controllers in MicroDexed. So I made comments for these calls in MiniDexed, hopefully the problems are fixed.

dcoredump avatar Nov 20 '23 09:11 dcoredump

Thanks @dcoredump. Unfortunately something is still wrong according to the test in https://github.com/probonopd/MiniDexed/issues/562#issuecomment-1819646675, so I am not merging this yet.

probonopd avatar Nov 20 '23 19:11 probonopd

Hello @dcoredump. You suspect the issue might be in MiniDexed, do you have a suspicion where we should look? Thanks.

probonopd avatar Jul 27 '24 09:07 probonopd

Build for testing: MiniDexed_2024-07-27-a3d47fb Use at your own risk.

github-actions[bot] avatar Jul 27 '24 10:07 github-actions[bot]

Hello @dcoredump. You suspect the issue might be in MiniDexed, do you have a suspicion where we should look? Thanks.

I think it must be MiniDexed because MicroDexed has no problems. This is the place where the modwheel code is used in MicroDexed.

I am currently very short of time and cannot look into MiniDexed code - sorry.

Hope this helps,

Holger

dcoredump avatar Jul 29 '24 09:07 dcoredump