Prithayan Barua comments

Results 16 comments of


                                            Prithayan Barua

[LinkModules] Add support to link hw modules

Thanks everyone for the initial feedback, this is ready for another iteration, please take a look.

[RFC][Sim] Add format string type and format specifier ops

> @prithayan is sim.printf used internally? @darthscsi , We don't use the `verif.print` op internally. The format string type looks good, would be useful for the `sim.plusargs` also.

[Seq] Add a new op interface for clock transformation ops. NFC

> Does `ClockMuxOp` need to have this interface? In that case `getClk` returning a single value seems not composable. Yeah, I was not sure about clock mux, for the use...

[Seq] Add a new op interface for clock transformation ops. NFC

Closing, as this can be accomplished via a simple function, the itnerface is not relevant.

[Seq] Add a new pass to sink clock_gate ops to the users

Thanks a lot @fabianschuiki and @uenoku for the feedback. The major issue in the previous iteration was multiple instances. I have handled that in this version. The other concern regarding...

[FIRRTL] Don't allow foreign types in wires or connects.

> @prithayan How breaking to you is this? Wire and connect is primarily being used with `libdn.channel` types, the wire serves a temporary, to use a value that is defined...