prisma icon indicating copy to clipboard operation
prisma copied to clipboard

fix(client): Consistent naming for GroupBy args

Open SevInf opened this issue 2 years ago • 3 comments

Most of other args use non-capitalized name. Follow up to #19606

SevInf avatar Jun 05 '23 13:06 SevInf

CodSpeed Performance Report

Merging #19610 consistent-groupby-name (068ed7d) will degrade performances by 47.07%.

Summary

🔥 0 improvements ❌ 1 regressions ✅ 3 untouched benchmarks

🆕 0 new benchmarks ⁉️ 0 dropped benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main consistent-groupby-name Change
typescript compilation ~50 Models 99.4 ms 187.8 ms -47.07%

codspeed-hq[bot] avatar Jun 05 '23 14:06 codspeed-hq[bot]

@SevInf Is this ready for a review? It looks like some tests are failing

Jolg42 avatar Jun 15 '23 16:06 Jolg42

@Jolg42 not yet, will fix it in the coming days

SevInf avatar Jun 15 '23 16:06 SevInf