engines-wrapper icon indicating copy to clipboard operation
engines-wrapper copied to clipboard

Add test

Open Jolg42 opened this issue 3 years ago • 3 comments

https://github.com/prisma/engines-wrapper/tree/main/packages/engines-version doesn't have any test

It would be better to have some test, so we can safely merge Renovate PRs like https://github.com/prisma/engines-wrapper/pull/240

Jolg42 avatar Jul 04 '22 08:07 Jolg42

The only code here that has some logic that could be tested and uses external dependencies is now the publish script and not the package itself, as far as I can tell.

aqrln avatar Jul 06 '22 14:07 aqrln

(Corollary: whichever contrived test we may add to https://github.com/prisma/engines-wrapper/tree/main/packages/engines-version, it probably won't help us much be able to merge Renovate PRs with confidence since it's not the code that will likely break if something is wrong with the updated dependencies)

aqrln avatar Jul 06 '22 14:07 aqrln

Indeed, we could have some "dry run mode" for the publish script and test what that does.

Jolg42 avatar Jul 06 '22 15:07 Jolg42

Since https://github.com/prisma/engines-wrapper/pull/441 we have a build action which will let us know if TS compilation fails.

Jolg42 avatar Apr 25 '23 06:04 Jolg42

I made it a dry publish in https://github.com/prisma/engines-wrapper/pull/442

Jolg42 avatar Apr 25 '23 07:04 Jolg42

I think we can close this now

Jolg42 avatar Apr 25 '23 07:04 Jolg42