ecosystem-tests icon indicating copy to clipboard operation
ecosystem-tests copied to clipboard

dataproxy/vercel-edge-functions should include edge runtime route

Open rtbenfield opened this issue 2 years ago • 1 comments

We discovered an issue with @prisma/extension-accelerate where vercel deploy would fail for Edge Function deployments with an error message regarding it's ability to resolve the package entrypoint. This was not an issue for Next.js edge functions; only for "other" runtime edge functions. We were able to work with the Vercel team to identify the issue. I came back to review the ecosystem test here to understand why it was undetected.

Our current tests in dataproxy/vercel-edge-functions use a Serverless API route and not a route configured with runtime: "edge". This resulted in the vercel deploy compatibility checks not validating the extension package for edge compatibility.

Would it make sense to incorporate an edge API route into the existing test structure in addition to the serverless route?

rtbenfield avatar Aug 31 '23 14:08 rtbenfield

I think dataproy/vercel-edge-functions actually tests Edge Functions via Edge Middleware, and the serverless function does nothing with Prisma.

So we should rename that project, and add one that actually uses an explicit edge function that uses Prisma.

janpio avatar Aug 31 '23 15:08 janpio