ecosystem-tests icon indicating copy to clipboard operation
ecosystem-tests copied to clipboard

test(dataproxy,deno): test deno data proxy client

Open kt3k opened this issue 3 years ago • 3 comments

kt3k avatar Jul 11 '22 11:07 kt3k

Note: tests fail with messages like

The environment variable `DATABASE_URL` resolved to an empty string.

Because the repository secrets are not exposed when a PR is done from a fork (GitHub security default)

We would need to

  • set a value for DENO_DATA_PROXY_URL in https://github.com/prisma/ecosystem-tests/settings/secrets/actions
  • push that PR branch manually to a branch inside the repository.

Jolg42 avatar Jul 11 '22 13:07 Jolg42

@millsp Could you push this branch to this repository?

I added DENO_DATA_PROXY_URL to utils/crypto/envVars.ts with the same value as other *_DATA_PROXY_URL values. I think now it points to the same data proxy endpoints. (So no need of addition of secrets, I guess).

kt3k avatar Oct 06 '22 08:10 kt3k

Your PR is now running at https://github.com/prisma/ecosystem-tests/pull/3134

millsp avatar Oct 12 '22 13:10 millsp

This will be merged via https://github.com/prisma/ecosystem-tests/pull/3134

janpio avatar Oct 17 '22 12:10 janpio