docs icon indicating copy to clipboard operation
docs copied to clipboard

Did not instruct to install @prisma/client

Open imMatheus opened this issue 3 years ago • 2 comments

Describe this PR

All the code uses the @prisma/client package to interact with prisma but it never gets said to install it from this specific docs

Changes

Added a single instruction to install @prisma/client

What issue does this fix?

No issue from the issues open on GitHub, but will help new devs get up and running with Prisma

Any other relevant information

No

imMatheus avatar Aug 11 '22 15:08 imMatheus

@imMatheus is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 11 '22 15:08 vercel[bot]

Deploy Preview for prisma2-docs ready!

Built without sensitive environment variables

Name Link
Latest commit 8529b2968e85994c72c1e1db15657869fa7cb074
Latest deploy log https://app.netlify.com/sites/prisma2-docs/deploys/62f51d43c288c8000933a00c
Deploy Preview https://deploy-preview-3596--prisma2-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 11 '22 15:08 netlify[bot]

Hey @imMatheus, thanks a lot for opening this PR.

The @prisma/client package is installed for you under the hood, so we don't need to explicitly install it.

It works like this in the Quickstart tutorial:

  1. run npx prisma migrate dev
  2. prisma migrate dev runs prisma generate
  3. prisma generate checks whether @prisma/client is installed; if not, it runs npm install @prisma/client

We want to keep the Quickstart minimal and focused on the actual steps that are needed to set up Prisma, so I'm going to close this PR.

However, please feel free to open issues and PRs in the docs repo in the future if anything doesn't make sense to you!

Thanks a lot for taking the time to make our documentation better, this is much appreciated 💚

nikolasburk avatar Nov 16 '23 10:11 nikolasburk