view_components icon indicating copy to clipboard operation
view_components copied to clipboard

TextFields with trailing text and closing icon are overlapping

Open HDinger opened this issue 1 year ago • 5 comments

Steps to reproduce

  • Create a TextField with trailing text and closing icon activated
render(Primer::Alpha::TextField.new(name: "my-text-field",
                                    label: "My text field",
                                    show_clear_button: true,
                                    trailing_visual: { text: { text: "days" } }))

Actual behavior

  • The closing icon overlaps the traling text
Image

Expected

  • The text and the icon should be next to each other

HDinger avatar Jan 29 '25 10:01 HDinger

Uh oh! @HDinger, at least one image you shared is missing helpful alt text. Check your issue body to fix the following violations:
  • Images should have meaningful alternative text (alt text) at line 16

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

github-actions[bot] avatar Jan 29 '25 10:01 github-actions[bot]

Hey @HDinger, thanks for filing this 😄 Would you or @bsatarnejad be able to take a look and submit a PR?

camertron avatar Feb 03 '25 18:02 camertron

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Aug 06 '25 19:08 github-actions[bot]

Please keep it open. We may open a PR for that in the future.

HDinger avatar Aug 07 '25 06:08 HDinger