view_components icon indicating copy to clipboard operation
view_components copied to clipboard

Prevent rounded corners in the middle of a BorderBox

Open HDinger opened this issue 1 year ago • 2 comments

What are you trying to accomplish?

In a Primer::Beta::BorderBox there are constellations in which there are rounded corners somewhere in the middle. For example

render(Primer::Beta::BorderBox.new) do |component|
  component.with_header { "Header" }
  component.with_body { "Body" }
  component.with_row { "Row one" }
  component.with_row { "Row two" }
end

Screenshots

Bildschirmfoto 2024-03-12 um 08 57 25

List the issues that this change affects.

Closes #2684

Risk Assessment

  • [x] Low risk the change is small, highly observable, and easily rolled back.
  • [ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • [ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Lookbook)
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

HDinger avatar Mar 12 '24 08:03 HDinger

🦋 Changeset detected

Latest commit: c3c60f0c839786ebff98e0bf5da48d2a1fabdb51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 12 '24 08:03 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar May 18 '24 09:05 github-actions[bot]