view_components icon indicating copy to clipboard operation
view_components copied to clipboard

No `indeterminate` state styling in check boxes

Open aaron-contreras opened this issue 2 years ago • 1 comments

It looks like the Primer::Alpha::CheckBox component is missing the indeterminate state styles as compared to the React components. Are there any plans to add these styles to Primer View Components as well?

aaron-contreras avatar Oct 17 '23 14:10 aaron-contreras

Hi @aaron-contreras 👋 Thanks for checking in about this. We don't have any current plans to prioritize the indeterminate state for PVC Checkbox, but the CSS for this feature does already exist over here: https://github.com/primer/view_components/blob/cc44952c1c84e4fcd3ad6dc786db7211cdb82d36/app/components/primer/alpha/text_field.pcss#L640

If you or someone else would like to contribute this back into PVC using the Primer React state and provided CSS as a model, we'd be happy to review! As a reference, here is the contribution guide for PVC: https://github.com/primer/view_components/blob/main/docs/contributors/README.md. Let us know if you have questions!

lesliecdubs avatar Oct 23 '23 21:10 lesliecdubs

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] avatar Apr 20 '24 22:04 github-actions[bot]