react icon indicating copy to clipboard operation
react copied to clipboard

Evenly space AvatarStack

Open joeoak opened this issue 9 months ago • 6 comments

Changelog

Changed

Proposed:

  • Avatars in AvatarStack are evenly spaced apart
  • Avatars in AvatarStack do not progressively fade in opacity

Risks:

  • AvatarStack is wider and breaks layouts (https://primer-query.githubapp.com/primer?name=avatarstack)
    • Proposal: Reduce --overlap-size?
    • Proposal: Reduce max number of Avatars?

Diff:

Before After
Current AvatarStack. Spacing between avatars varies depending on index. Updated AvatarStack. Avatars are evenly spaced apart.

https://github.com/user-attachments/assets/f9d63cee-d4bd-43eb-88bf-7bbb3bf74205

Rollout strategy

  • [ ] Patch release
  • [x] Minor release
  • [ ] Major release; if selected, include a written rollout or migration plan
  • [ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Storybook)
  • [ ] Changes are SSR compatible
  • [x] Tested in Chrome
  • [ ] Tested in Firefox
  • [x] Tested in Safari
  • [ ] Tested in Edge
  • [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

joeoak avatar Apr 09 '25 20:04 joeoak

⚠️ No Changeset found

Latest commit: 5ea313bd26d50a1d636a89a5ce4faf80baa3d5db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 09 '25 20:04 changeset-bot[bot]

:wave: Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions[bot] avatar Apr 09 '25 20:04 github-actions[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.32 KB (-0.12% 🔽)
packages/react/dist/browser.umd.js 104.68 KB (-0.08% 🔽)

github-actions[bot] avatar Apr 09 '25 21:04 github-actions[bot]

👋🏻 Hey @joeoak, thanks for giving this fix a go! Is it ready for review?

lesliecdubs avatar Apr 26 '25 04:04 lesliecdubs

hey @lesliecdubs! I opened this as more of a proposal 😅 - so I think we still need to align on whether this is the right design decision

cc @lukasoppermann @mperrotti

joeoak avatar Apr 28 '25 20:04 joeoak

Hey, I am on board with the change in general, but would suggested to decrease spacing the more items are added, to reduce the overall size when 4 or 5 Avatars are displayed.

lukasoppermann avatar Apr 29 '25 10:04 lukasoppermann

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Jun 28 '25 11:06 github-actions[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Aug 29 '25 07:08 github-actions[bot]