react icon indicating copy to clipboard operation
react copied to clipboard
verified publisher icon primer

`Stack` `justify` prop has no effect

Open iansan5653 opened this issue 1 year ago • 1 comments

Description

Stack accepts a justify prop that is supposed to align with the justify-content CSS property. But setting it has no effect other than setting the data-justify attribute on the HTML element - it doesn't update the CSS.

Steps to reproduce

<Stack justify="space-between">
  <span>a</span>
  <span>b</span>
</Stack>

Version

v36.17.0

Browser

Chrome

iansan5653 avatar May 10 '24 17:05 iansan5653

Hmm, seems like we're missing the styles for this responsive prop 🤔 @langermank did we just miss these or were the lost during the transition/renames? 😅

joshblack avatar May 10 '24 17:05 joshblack

Hi @iansan5653 , I am looking for some open source projects to work on. If this is issue is still open and hasn't been resolved, I'm interested in contributing to this issue.

Adarsha186 avatar May 16 '24 15:05 Adarsha186

Hey @Adarsha186! Thanks so much for offering to help! This had a PR open over at #4591 but just wanted to say that if there are any other issues that you're interested in helping out with definitely let us know! We always appreciate the help 🙏

joshblack avatar May 16 '24 16:05 joshblack

@Adarsha186 of course we are always happy to accept contributions! Here's a query for unassigned issues with smaller size estimates that may be good candidates: https://github.com/primer/react/issues?q=is%3Aissue%20state%3Aopen%20no%3Aassignee%20label%3A%22size%3A%20sand%22%2C%22size%3A%20pebble%22

iansan5653 avatar May 16 '24 16:05 iansan5653