Action Bar - Experimental component
Create a new experimental component called ActionBar which is a horizontal list of icon buttons to be used in the Comment Editor.
Here's a demo of the storybook complete with overflow behaviour
https://github.com/primer/react/assets/417268/7670f321-0df9-4925-ba47-ddc25788bf2a
Closes #https://github.com/github/primer/issues/3020
Changelog
New
In this PR
- Add an experimental component
ActionBaridentical to functionality of its rails counterpart. - Add overflow behaviour with resize observer
- Add size attribute
- Add divider and icon component
- Add documentation
- Add storybook with 3 stories.
Rollout strategy
- [ ] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [x] None; if selected, include a brief description as to why
This PR does not need a changeset since it only introduces a draft or experimental component.
Testing & Reviewing
Please test using the storybook deployment
Merge checklist
- [ ] Added/updated tests
- [x] Added/updated documentation
- [x] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [x] Tested in Chrome
- [x] Tested in Firefox
- [x] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: a1f5ca67608828a54db77b2663d8e01667339e27
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 113.49 KB (0%) |
| packages/react/dist/browser.umd.js | 114.16 KB (0%) |
How are you assessing for accessibility for this component?
@JoseInTheArena - My first tests will be to use VoiceOver and makes sure the announcements are coherent. Along with that I also test keyboard accessibility and support for 200% zoom. After this I will ask accessibility team for help with further review by applying to attend office hours.