react icon indicating copy to clipboard operation
react copied to clipboard

Support ReactNode in ActionMenu.Overlay

Open siddharthkp opened this issue 3 years ago • 3 comments

Created from https://github.com/primer/react/pull/2168 by @jdrush89

Describe your changes here.

Add support for ReactNode as the child type in ActionMenu.Overlay so that conditional children can be rendered within an overlay. Closes #2067

Screenshots

No visual changes

Merge checklist

  • [ ] Added/updated tests - current testing doesn't seem granular enough to warrant testing every possible prop type, I can add a test if it seems necessary though.
  • [x] Added/updated documentation
  • [x] Tested in Chrome
  • [x] Tested in Firefox
  • [x] Tested in Safari
  • [x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

siddharthkp avatar Jul 26 '22 14:07 siddharthkp

🦋 Changeset detected

Latest commit: 23ee0fe563f58766795e166d01f4ff374926a081

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 26 '22 14:07 changeset-bot[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 75.63 KB (0%)
dist/browser.umd.js 76.24 KB (0%)

github-actions[bot] avatar Jul 26 '22 14:07 github-actions[bot]

@jdrush89 A canary version is published for each commit

image

you can install this one by running npm install @primer/[email protected] in the repo you want to install like memex

siddharthkp avatar Jul 26 '22 14:07 siddharthkp

@siddharthkp I tested with the canary package in a memex codespace and all looks good, I'm able to specify false and null as Overlay children and everything's working as expected.

jdrush89 avatar Aug 15 '22 15:08 jdrush89

That's perfect! I'll merge this tomorrow and add it to the next release :)

siddharthkp avatar Aug 15 '22 16:08 siddharthkp