css icon indicating copy to clipboard operation
css copied to clipboard

Use tabular numbers in tables

Open robinwhittleton opened this issue 1 year ago • 1 comments

What are you trying to accomplish?

As tables are frequently used for comparing columns of numeric data (and have the ability to be right-aligned) we should make sure that we make it as easy as possibly. Toggling tabular numbers on givens you the ability to scan columns of numbers effectively, assuming the font supports it.

Here’s an example from a recent PR without this CSS:

Screenshot 2024-08-16 at 17 48 13

and with font-variant: tabular-nums:

Screenshot 2024-08-16 at 17 48 01

What approach did you choose and why?

Flipping the switch with CSS is trivial. If the font doesn’t support this functionality then this doesn’t have any effect, but is no worse than the current behaviour.

What should reviewers focus on?

First commit to Primer. Please let me know if I’m doing anything wrong, especially with the changeset which is new to me.

Can these changes ship as is?

  • [x] Yes, this PR does not depend on additional changes. 🚢

robinwhittleton avatar Aug 16 '24 15:08 robinwhittleton

🦋 Changeset detected

Latest commit: 02bb2220d39cc3da0edbd2b406449f76d6ece811

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 16 '24 15:08 changeset-bot[bot]