feat(DataTable): Add prop to allow range selection over multiple pages
~~### Defect Fixes Fix #7778: When accessing processedData, props.first is now correctly substracted from rowIndex to get the right index in the array.~~
Feature Requests
~~Additionally,~~ anchorRowIndex was needlessly resetted on each page change, prohibiting selection over multiple pages. This is now possible through the new prop multiPageRangeSelection
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.
Deployment failed with the following error:
Creating the Deployment Timed Out.
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.
@rayman-de this is great but we should check PrimeVue and whether it behaves correctly or incorreclty. I don't like adding new props that don't match PrimeVue unless absolutely necessary.
I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue
I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue
Well I have not done any programming with Vue yet, so I cannot do much with that Stackblitz.
What is the desired behaviour? Of course, we could allow range selections over multiple pages by default, I just was not sure whether that is wanted
yeah your PR makes sense to me.
I assigned to PrimeTek to review.
Thanks!
What does the failed Vercel check mean? Is there a mistake in the PR?
Oh its failing the PrimeReact v9 deployment but that has been broken for a while you don't need to worry about it.
Should I maybe splitt off the feature-request part here so that you can just merge the bugfixing part without having to wait for @mertsincan ?
Yes open another PR with just the bugfix part please.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| primereact | ⬜️ Ignored (Inspect) | Visit Preview | Mar 19, 2025 0:35am |
| primereact-v9 | ⬜️ Ignored (Inspect) | Visit Preview | Mar 19, 2025 0:35am |
Hmm, I cannot change the branch name for this PR (which is now just the multiPageRangeSelection prop
Yes open another PR with just the bugfix part please.
Here: #7799
OK i just rebased this branch!