primereact icon indicating copy to clipboard operation
primereact copied to clipboard

feat(DataTable): Add prop to allow range selection over multiple pages

Open rayman-de opened this issue 10 months ago • 18 comments

~~### Defect Fixes Fix #7778: When accessing processedData, props.first is now correctly substracted from rowIndex to get the right index in the array.~~

Feature Requests

~~Additionally,~~ anchorRowIndex was needlessly resetted on each page change, prohibiting selection over multiple pages. This is now possible through the new prop multiPageRangeSelection

rayman-de avatar Mar 13 '25 09:03 rayman-de

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

github-actions[bot] avatar Mar 13 '25 09:03 github-actions[bot]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

github-actions[bot] avatar Mar 13 '25 10:03 github-actions[bot]

Deployment failed with the following error:

Creating the Deployment Timed Out.

vercel[bot] avatar Mar 13 '25 10:03 vercel[bot]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

github-actions[bot] avatar Mar 13 '25 10:03 github-actions[bot]

@rayman-de this is great but we should check PrimeVue and whether it behaves correctly or incorreclty. I don't like adding new props that don't match PrimeVue unless absolutely necessary.

melloware avatar Mar 13 '25 11:03 melloware

I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue

melloware avatar Mar 13 '25 11:03 melloware

I created a stackblitz is LOOKS like PrimeVue has the same bug? https://stackblitz.com/edit/x8rejugz?file=src%2FApp.vue

Well I have not done any programming with Vue yet, so I cannot do much with that Stackblitz.

What is the desired behaviour? Of course, we could allow range selections over multiple pages by default, I just was not sure whether that is wanted

rayman-de avatar Mar 13 '25 12:03 rayman-de

yeah your PR makes sense to me.

melloware avatar Mar 13 '25 12:03 melloware

I assigned to PrimeTek to review.

melloware avatar Mar 13 '25 12:03 melloware

Thanks!

rayman-de avatar Mar 13 '25 12:03 rayman-de

What does the failed Vercel check mean? Is there a mistake in the PR?

rayman-de avatar Mar 13 '25 12:03 rayman-de

Oh its failing the PrimeReact v9 deployment but that has been broken for a while you don't need to worry about it.

melloware avatar Mar 13 '25 13:03 melloware

Should I maybe splitt off the feature-request part here so that you can just merge the bugfixing part without having to wait for @mertsincan ?

rayman-de avatar Mar 19 '25 07:03 rayman-de

Yes open another PR with just the bugfix part please.

melloware avatar Mar 19 '25 11:03 melloware

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 0:35am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 0:35am

vercel[bot] avatar Mar 19 '25 12:03 vercel[bot]

Hmm, I cannot change the branch name for this PR (which is now just the multiPageRangeSelection prop

rayman-de avatar Mar 19 '25 12:03 rayman-de

Yes open another PR with just the bugfix part please.

Here: #7799

rayman-de avatar Mar 19 '25 12:03 rayman-de

OK i just rebased this branch!

melloware avatar Mar 19 '25 12:03 melloware