primereact icon indicating copy to clipboard operation
primereact copied to clipboard

feat #6772 : defaultVisible prop added

Open jpranays opened this issue 1 year ago • 4 comments

defaultVisible Prop to Dialog Component

Fix #6772

This pull request introduces a new defaultVisible prop to the Dialog component in our UI library. The defaultVisible prop allows developers to control the initial visibility of the Dialog when the component mounts.

Description

The defaultVisible prop is a boolean that, when set to true, ensures that the Dialog is displayed immediately upon mounting. Conversely, setting this prop to false or omitting it entirely will maintain the default behavior, where the Dialog is hidden initially and requires a trigger to become visible.

Changes

  • Added defaultVisible prop to the Dialog component's API.
  • Updated the Dialog component's internal state management to account for the defaultVisible prop.
  • Ensured backward compatibility by defaulting the defaultVisible prop to false.

Usage

<Dialog defaultVisible={true}>
    <!-- Dialog content goes here -->
</Dialog>

jpranays avatar Jun 19 '24 11:06 jpranays

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 0:02am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 0:02am

vercel[bot] avatar Jun 19 '24 11:06 vercel[bot]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

github-actions[bot] avatar Jun 19 '24 11:06 github-actions[bot]

Any update on this ?

jpranays avatar Jun 23 '24 09:06 jpranays

Any update on this ?

It is assigned to PrimeTek for their review.

melloware avatar Jun 23 '24 11:06 melloware

Thank you for bringing this issue to our attention and for your valuable contribution. We truly appreciate the effort you put into this pull request.

However, after careful consideration, we have decided to reject the pull request. Our decision is based on the need to maintain synchronization across multiple UI libraries that we are currently developing. Additionally, we believe that this feature might lead to confusion among other users.

We hope you understand our decision, and we look forward to any future contributions you may have.

@jpranays

nitrogenous avatar Jul 03 '24 09:07 nitrogenous