Password: (accessiblility) cannot access toggle button using keyboard

[arnodemer]

Describe the bug

focus cannot be moved to Password's toggle button, then cannot toggle using keyboard

Reproducer

No response

PrimeReact version

10.5.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

1. go to Password toggle show case : https://primereact.org/password/#togglemask
2. use tab to set focus on password field
3. hit tab several times, focus is never set on toggle password button

Expected behavior

Toggle button should be able to be activated using keyboard Focus should also stay on toggle button when password state is toggled.

[melloware]

Agreed it looks like PrimeVue has not implemented this yet either.

[akshayaqburst]

@melloware Can I work on this?

[arnodemer]

Hi ! it would be nice if we could also set a tooltip for this toggle button (password component already have one, but it's for input ). Thanks a lot !

[melloware]

@akshayaqburst sure!

[akshayaqburst]

@melloware Created PR for review - https://github.com/primefaces/primereact/pull/6052. Thanks,

[melloware]

Some code review comments. Looking good so far!