primereact icon indicating copy to clipboard operation
primereact copied to clipboard

Dialog: inconsistency between theming documentation and used classnames (from source code)

Open arnodemer opened this issue 1 year ago • 1 comments

Describe the bug

Dialog theming documenation (10.5.1) deals with 'p-dialog-titlebar' whereas sourcecode deals with: 'p-dialog-header'

Reproducer

No response

PrimeReact version

10.5.1

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Go to Dialog component theming page: https://primereact.org/dialog/ doc. describe p-dialog-titlebar various classnames Go to source code: https://github.com/primefaces/primereact/blob/master/components/lib/dialog/DialogBase.js titllebar is no more used (was in the past), but replaced by header.

Expected behavior

documentation should be inline with real classnames

arnodemer avatar Feb 21 '24 13:02 arnodemer

Panel component also use titlebar from its documentation page: https://primereact.org/panel/ But source code use *header instead: https://github.com/primefaces/primereact/blob/master/components/lib/panel/PanelBase.js

arnodemer avatar Feb 21 '24 13:02 arnodemer