v0.16.0 compatibility

[miharekar]

There were a ton of changes and ATM Primary doesn't look great 😬

The biggest issue is that scrolling simply doesn't work in settings.

[pastordan]

Scrolling seems to work for me on notes, but not in modals, which is...not great. The other issue I've noticed is that bullets are wonky:

[Mara-Li]

Primary is totally broken by the 0.16 update. A lot of things is totally unusable (i.e. scrolling)

[pastordan]

Here are some CSS patches while Cecilia works out the kinks:

/*16.0 broke a lot of shit */ .markdown-source-view.mod-cm6 .callout { padding: 0; border: 1px solid transparent; border-radius: 0; transition: var --duration-superfast; }

.md-bullet-color-muted.theme-light span.cm-formatting.cm-formatting-list, .md-bullet-color-muted.theme-light span.list-bullet, .md-bullet-color-muted.theme-light li::marker, .md-bullet-color-muted.theme-dark span.cm-formatting.cm-formatting-list, .md-bullet-color-muted.theme-dark span.list-bullet, .md-bullet-color-muted.theme-dark li::marker, markdown-rendered.list-bullet, list-bullet { color: var(--background-secondary); }

svg.svg-icon.lucide-edit-3 path:first-of-type { color: var(--callout-title-background); }

.workspace-ribbon.mod-left:before { padding-bottom: 19px; }

div.side-dock-actions {margin-top: 19px; }

.mod-left-split .workspace-tab-header-container-inner, .mod-right-split .workspace-tab-header-container-inner { gap: 10px; }

div.workspace-tab-header { padding-right: 5px !important; padding-left: 5px !important; }

I'm not smart enough to figure out how to fix the scrolling issue, though.

On Tue, Aug 30, 2022 at 10:53 AM Lisandra Simonetti < @.***> wrote:

Primary is totally broken by the 0.16 update. A lot of things is totally unusable (i.e. scrolling)

— Reply to this email directly, view it on GitHub https://github.com/ceciliamay/obsidianmd-theme-primary/issues/154#issuecomment-1231856820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2C6QCPN3EZHU6IBNTNGILV3YU6NANCNFSM6AAAAAAQAIZSIA . You are receiving this because you commented.Message ID: @.***>

[Mara-Li]

The broken scroll is because of : .modal {overflow-y: hidden}

So, to fix it :

.modal,
.vertical-tab-content-container,
.modal.mod-settings .vertical-tabs-container,
.modal.mod-settings .modal-content {
    overflow: auto !important;
}

Also, for settings background :

.theme-dark .modal .modal-content .vertical-tab-header,
.theme-dark .modal .modal-content .vertical-tab-content-container .vertical-tab-content {
    background-color: var(--background-secondary) !important;
}

[pastordan]

That didn't work for me, but this did:

.modal.mod-settings .modal-content { overflow-y: scroll !important; }

Thanks for the hint!

On Tue, Aug 30, 2022 at 5:09 PM Lisandra Simonetti @.***> wrote:

The broken scroll is because of : .modal {overflow-y: hidden}

So, to fix it :

.modal { overflow-y: auto !important; }

Also, for settings background :

.theme-dark .modal .modal-content .vertical-tab-header, .theme-dark .modal .modal-content .vertical-tab-content-container .vertical-tab-content { background-color: var(--background-secondary) !important; }

— Reply to this email directly, view it on GitHub https://github.com/ceciliamay/obsidianmd-theme-primary/issues/154#issuecomment-1232219584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2C6QBGNYLBVK3YDCWAPHLV32BBLANCNFSM6AAAAAAQAIZSIA . You are receiving this because you commented.Message ID: @.***>

[Mara-Li]

Seems broken because when I scroll to down, I can't see any option... We must to wait @ceciliamay an update/fix for 0.16 :/

[miharekar]

Here's a theme migration guide that should help.

[aquatix]

Version 1.0 of Obsidian just was released, and I'm now on the default theme instead of the goodness that is Primary. Hopefully we can fix compatibility soon :)

Let me/us know if we as the community can help out, as I am aware that there has been significant changes going to the new engine.

[miharekar]

Closing because 0.16 got rebranded as 1.0 and the discussion is continued in #164